Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More HPR ammo in req #5097

Closed
wants to merge 1 commit into from
Closed

More HPR ammo in req #5097

wants to merge 1 commit into from

Conversation

CapCamIII
Copy link
Contributor

@CapCamIII CapCamIII commented Dec 1, 2023

About the pull request

about doubles normal hpr ammo in req(to about 3x the amount of hprs), puts a tiny bit more holotargetting in req(to just over the amount of hprs)

Explain why it's good for the game

not having enough ammo to equip everyone who takes an hpr sucks why was it this low

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
balance: there is about double the normal hpr ammo in req vendors now
balance: there is slightly more holo-targetting hpr ammo in req vendors now
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Dec 1, 2023
@fira
Copy link
Member

fira commented Dec 1, 2023

????? HPR ammo in Reqs almost never runs out and practically nobody wants to use the Holo Target boxes

@CapCamIII
Copy link
Contributor Author

CapCamIII commented Dec 2, 2023

????? HPR ammo in Reqs almost never runs out and practically nobody wants to use the Holo Target boxes

@fira
not to current round BUUUUT it ran out roundstart with 2 people taking it(including me) and i had no ammo :D

@ihatethisengine
Copy link
Contributor

ihatethisengine commented Dec 2, 2023

@fira not to current round BUUUUT it ran out roundstart with 2 people taking it(including me) and i had no ammo :D

You can just refill the boxes :\
Every HPR kit comes with 2 boxes + holo, just refill the boxes. You kinda supposed to.

@Diegoflores31
Copy link
Contributor

i am pretty sure restricted weapons are not supposed to be abundant on ammunition at roundstart , also if you add the amount of ammo there is already at prep i think this may not be good balance wise

@CapCamIII
Copy link
Contributor Author

@ihatethisengine there is 1(one) normal ammo box in the kit(not including the one in the magazine), and holo is bad(and also can't be refilled), meaning with the amount of mags in vendor you have 3 mags
@Diegoflores31 there are none at prep, and the ammo would not be "abundant" with this change, it would simply be enough to actually have enough to go with the amount of guns there are, right now its 1 drum per gun in the req vendors

@ihatethisengine
Copy link
Contributor

@ihatethisengine there is 1(one) normal ammo box in the kit(not including the one in the magazine), and holo is bad(and also can't be refilled), meaning with the amount of mags in vendor you have 3 mags

So as I said, you have 2 normal boxes and 1 holo. You have 800 round in the kit. 600 of them refillable, we can ignore holo since it's bad. If you carry Mk1 even if you take noobtrap ammo belt, you'll barely have the same amount of ammo, with Mk2 you'll have way less. Just refill when you're out of ammo??? Alternatively you can replace holo with normal box, since everyone is ditching holo anyway. If anyone wants holo they can ask req. Also, this is out of scope, but I am not sure if hpr boxes should fit in mag pouches/armor/webbings, but w/e.

@fira
Copy link
Member

fira commented Dec 3, 2023

????? HPR ammo in Reqs almost never runs out and practically nobody wants to use the Holo Target boxes

@fira not to current round BUUUUT it ran out roundstart with 2 people taking it(including me) and i had no ammo :D

Overall Reqs balance is subject to TM tests right now, there's been rounds with a lot more or less supply, it's a bit hard to compare

On top of the general reqs buffs there's [[#5018]] which replaces back the MK1 spawns by HPR boxes as was intended initially

I really don't think Reqs gonna need any more

Edit: IIRC this PR was made after reduction of latejoin scaling and before i realized #4939 bugfixes cut marine roundstart supply by almost in half on high pop, so that just might be why you think there weren't enough

@Birdtalon
Copy link
Contributor

As Fira said above: req balance is subject to large changes currently under #4939 and #5018

I believe this PR should be not be considered until after those have been appropriately balanced and merged.

@Zonespace27 Zonespace27 added the Do Not Merge If you merge this PR, I will annihilate you label Dec 7, 2023
@Zonespace27
Copy link
Contributor

DNM until #4939 and #5018 have been merged or closed.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Dec 7, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Zonespace27 Zonespace27 removed the Do Not Merge If you merge this PR, I will annihilate you label Dec 9, 2023
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Dec 17, 2023
@github-actions github-actions bot closed this Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Merge Conflict PR can't be merged because it touched too much code Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants